Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

regression: failing to create rooms in some integrations #30649

Merged
merged 1 commit into from
Oct 16, 2023
Merged

regression: failing to create rooms in some integrations #30649

merged 1 commit into from
Oct 16, 2023

Conversation

pierre-lehnen-rc
Copy link
Contributor

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

@changeset-bot
Copy link

changeset-bot bot commented Oct 16, 2023

⚠️ No Changeset found

Latest commit: 325af72

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@pierre-lehnen-rc pierre-lehnen-rc added this to the 6.5.0 milestone Oct 16, 2023
@codecov
Copy link

codecov bot commented Oct 16, 2023 •
edited
Loading

Codecov Report

Merging #30649 (325af72) into develop (b22da64) will decrease coverage by 0.15%.
Report is 2 commits behind head on develop.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #30649      +/-   ##
===========================================
- Coverage    51.29%   51.15%   -0.15%     
===========================================
  Files          811      805       -6     
  Lines        15059    15074      +15     
  Branches      2751     2785      +34     
===========================================
- Hits          7725     7711      -14     
- Misses        6926     6931       +5     
- Partials       408      432      +24
Flag Coverage Δ
e2e 48.46% <ø> (-0.11%) ⬇️
unit 64.80% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@rodrigok
Copy link
Member

Fucking JS files 😢

@rodrigok
Copy link
Member

QA will be complex on this one, should we skip it?

@sampaiodiego sampaiodiego modified the milestones: 6.5.0, 6.4.2 Oct 16, 2023
@sampaiodiego sampaiodiego marked this pull request as ready for review October 16, 2023 20:35
@sampaiodiego sampaiodiego merged commit a0dcc38 into develop Oct 16, 2023
@sampaiodiego sampaiodiego deleted the fix/create-room-params branch October 16, 2023 20:35
sampaiodiego pushed a commit that referenced this pull request Oct 16, 2023
@pierre-lehnen-rc @sampaiodiego
regression: failing to create rooms in some integrations (#30649)
4b4e045
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rodrigok rodrigok rodrigok approved these changes

@sampaiodiego sampaiodiego sampaiodiego approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
6.4.2
Development

Successfully merging this pull request may close these issues.
3 participants
@pierre-lehnen-rc @rodrigok @sampaiodiego